[Analytics Hub] Return the direction of the delta along with formatted delta percentage #8202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #8149
Description
When we format the delta percentage to display on an Analytics card (e.g.
+36%or-16%) we also need to keep track of the direction of change (positive, negative, or zero). This PR updates the stats data formatter so it returns both the formatted string and direction of change for a stats delta percentage.It also includes a couple small fixes to the calculations.
Changes
DeltaPercentagestruct to represent the formatted string and direction of change, and returns that (instead of just aString) from the corresponding formatter methods.+0%(previously it was incorrectly returning+100%).-100%(previously it was returning+100%).Testing
These delta percentages aren't yet used in the app; confirm the unit tests are checking the correct values and tests pass.
Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.